Update messaging in AddCustomerMatchUserList example#357
Merged
devchas merged 4 commits intogoogleads:masterfrom Oct 27, 2020
Merged
Update messaging in AddCustomerMatchUserList example#357devchas merged 4 commits intogoogleads:masterfrom
devchas merged 4 commits intogoogleads:masterfrom
Conversation
Change-Id: I9cec5b2a44d3bb4808f552af19fe714a0f382eb7
jradcliff
requested changes
Oct 20, 2020
Change-Id: I387057f002c96be24f82b8690b48737079b67e43
nwbirnie
reviewed
Oct 20, 2020
| System.out.println("Waiting until operation completes."); | ||
|
|
||
| // The polling future implements a default back-off policy for retrying. | ||
| // Note: Retrieving the results of the asynchronous request is for demonstrative purposes only |
Contributor
There was a problem hiding this comment.
Can we give guidance for how to restart polling asynchronously? It seems like this could be a source of confusion...
Member
There was a problem hiding this comment.
I experimented with getting the LRO handle again when I worked on the Stores Sales upload example, and found that process confusing as well. This is why that example just prints out a GAQL query the user can use to come back and check on the results of the LRO later:
WDYT of going with that approach here?
Contributor
Author
There was a problem hiding this comment.
SGTM as well. I've also added an option to print the results if the status is SUCCESS.
Change-Id: Ia6322cf443253e488e2701d8aed72f141e9afd8e
Change-Id: I9a3affa7cc8a6bf9fc55554d98bba265562e0ddd
jradcliff
approved these changes
Oct 23, 2020
nwbirnie
approved these changes
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #353